Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend ci error handling #352

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

hwinther
Copy link
Owner

@hwinther hwinther commented Nov 6, 2024

Description 💬

Motivation and Context 🥅

How has this been tested? 🧪

  • Local build ⚒️
  • Local tests 🧪
  • (optional) Local run and endpoint tested in swagger 🚀

Screenshots (if appropriate) 💻

Types of changes 🌊

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist ☑️

  • The pull request title starts with the jira case number (when applicable), e.g. "TEST-1234 Add some feature"
  • The person responsible for following up on requested review changes has been assigned to the pull request
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Highly optional checks, only use these if you have a reason to do so ✔️

  • This PR changes the database so I have added the create-diagram label to assist reviewers with a db diagram
  • This PR changes platform or backend and I need others to be able to test against these changes before merging to dev, so I have added the deploy-azure label to deploy before merging the PR

Checklist for the approver ✅

  • I've checked the files view for spelling issues, code quality warnings and similar
  • I've waited until all checks have passed (green check/without error)
  • I've checked that only the intended files are changed

@hwinther hwinther enabled auto-merge (squash) November 6, 2024 20:27
Copy link

github-actions bot commented Nov 6, 2024

frontend

❌ The following build issues should be fixed:

  • ❌ src/pages/about/+Page.tsx(1,1): error TS6133: 'React' is declared but its value is never read.

✅ No linting issues 🎊

Copy link

github-actions bot commented Nov 6, 2024

Todo Commenter

.github/actions/frontend-build/action.yml
TODO:
  • ,FIXME:,BUG:" Line: 172
FIXME:
  • ,BUG:" Line: 172
BUG:
  • " Line: 172

@hwinther Please take a look 👀

@hwinther hwinther force-pushed the feature/TEST-0009-fix-frontend-ci branch from 8bb8cae to e146691 Compare November 6, 2024 20:38
@hwinther hwinther disabled auto-merge November 6, 2024 20:38
@hwinther hwinther merged commit cf6d171 into dev Nov 6, 2024
19 checks passed
@hwinther hwinther deleted the feature/TEST-0009-fix-frontend-ci branch November 6, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant