Update tags saver to use Yaml

hydephp · Jan 16, 2023 · 970b681 · 970b681
1 parent d2fbfad
commit 970b681
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 11 deletions.
diff --git a/packages/publications/src/Models/PublicationTags.php b/packages/publications/src/Models/PublicationTags.php
@@ -82,7 +82,7 @@ public function addTagsToGroup(string $name, array|string $values): self
      */
     public function save(): self
     {
-        Filesystem::putContents('tags.yml', json_encode($this->tags, JSON_PRETTY_PRINT));
+        Filesystem::putContents('tags.yml', Yaml::dump($this->tags->toArray()));
 
         return $this;
     }

diff --git a/packages/publications/tests/Feature/MakePublicationTagCommandTest.php b/packages/publications/tests/Feature/MakePublicationTagCommandTest.php
@@ -36,7 +36,13 @@ public function testCanCreateNewPublicationTag()
 
         $this->assertFileExists(Hyde::path('tags.yml'));
         $this->assertSame(
-            json_encode(['foo' => ['foo', 'bar', 'baz']], 128),
+            <<<'YAML'
+            foo:
+                - foo
+                - bar
+                - baz
+
+            YAML,
             file_get_contents(Hyde::path('tags.yml'))
         );
     }
@@ -55,7 +61,13 @@ public function testCanCreateNewPublicationTagWithTagNameArgument()
 
         $this->assertFileExists(Hyde::path('tags.yml'));
         $this->assertSame(
-            json_encode(['foo' => ['foo', 'bar', 'baz']], 128),
+            <<<'YAML'
+            foo:
+                - foo
+                - bar
+                - baz
+
+            YAML,
             file_get_contents(Hyde::path('tags.yml'))
         );
     }

diff --git a/packages/publications/tests/Feature/PublicationTagsTest.php b/packages/publications/tests/Feature/PublicationTagsTest.php
@@ -150,14 +150,12 @@ public function testCanSaveTagsToDisk()
         $tags->save();
 
         $this->assertSame(
-            <<<'JSON'
-            {
-                "test": [
-                    "test1",
-                    "test2"
-                ]
-            }
-            JSON, file_get_contents(Hyde::path('tags.yml'))
+            <<<'YAML'
+            test:
+                - test1
+                - test2
+
+            YAML, file_get_contents(Hyde::path('tags.yml'))
         );
 
         unlink(Hyde::path('tags.yml'));