Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route list improvement ideas for dynamic pages #1102

Closed
caendesilva opened this issue Feb 23, 2023 · 1 comment · Fixed by #1111
Closed

Route list improvement ideas for dynamic pages #1102

caendesilva opened this issue Feb 23, 2023 · 1 comment · Fixed by #1111

Comments

@caendesilva
Copy link
Member

caendesilva commented Feb 23, 2023

Just thinking out loud here for something I noticed when working on #1099 on the publications feature branch. (Ignore the .html.html extension)

image

Two things here, publication page's source files are only partly dynamic at run time, and if you have many InMemoryPages would be nice if they had some more information.

So instead, I'd think something like this would be cool:

+---------------------------+------------------------------------+--------------------------------------------+---------------------------------+ 
| Page Type                 | Source File                        | Output File                                | Route Key                       | 
+---------------------------+------------------------------------+--------------------------------------------+---------------------------------+ 
| BladePage                 | _pages/404.blade.php               | _site/404.html                             | 404                             | 
| BladePage                 | _pages/index.blade.php             | _site/index.html                           | index                           | 
| PublicationPage           | test/fringilla-dapibus-ad.md       | _site/test/fringilla-dapibus-ad.html       | test/fringilla-dapibus-ad       | 
| PublicationPage           | test/egestas-aliquet-amet.md       | _site/test/egestas-aliquet-amet.html       | test/egestas-aliquet-amet       | 
| PublicationPage           | test/fermentum-neque-per.md        | _site/test/fermentum-neque-per.html        | test/fermentum-neque-per        | 
| PublicationPage           | test/sagittis-eros-felis.md        | _site/test/sagittis-eros-felis.html        | test/sagittis-eros-felis        | 
| PublicationPage           | test/aliquam-sagittis-potenti.md   | _site/test/aliquam-sagittis-potenti.html   | test/aliquam-sagittis-potenti   | 
| PublicationPage           | test/non-molestie-morbi.md         | _site/test/non-molestie-morbi.html         | test/non-molestie-morbi         | 
| PublicationPage           | test/interdum-porta-eu.md          | _site/test/interdum-porta-eu.html          | test/interdum-porta-eu          | 
| PublicationPage           | test/est-sociosqu-sociosqu.md      | _site/test/est-sociosqu-sociosqu.html      | test/est-sociosqu-sociosqu      | 
| PublicationPage           | test/vestibulum-ante-adipiscing.md | _site/test/vestibulum-ante-adipiscing.html | test/vestibulum-ante-adipiscing | 
| PublicationPage           | test/rutrum-imperdiet-fringilla.md | _site/test/rutrum-imperdiet-fringilla.html | test/rutrum-imperdiet-fringilla | 
| PublicationListPage       | dynamic                            | _site/test/index.html                      | test/index                      | 
| InMemoryPage (TagPage)    | dynamic                            | _site/tags/index.html.html                 | tags/index.html                 | 
| InMemoryPage (TagPage)    | dynamic                            | _site/tags/10.html.html                    | tags/10.html                    | 
| InMemoryPage (TagPage)    | dynamic                            | _site/tags/g.html.html                     | tags/g.html                     | 
| InMemoryPage (TagPage)    | dynamic                            | _site/tags/d.html.html                     | tags/d.html                     | 
| InMemoryPage (TagPage)    | dynamic                            | _site/tags/.html.html                      | tags/.html                      | 
| InMemoryPage (TagPage)    | dynamic                            | _site/tags/12.html.html                    | tags/12.html                    | 
+---------------------------+------------------------------------+--------------------------------------------+---------------------------------+ 

For in memory pages this could probably be as easy as adding an (optional!) macro. Maybe ['typeLabel']? The type label could also be used when creating the progress bars during the site build.

caendesilva added a commit that referenced this issue Feb 24, 2023
Will allow publication pages to show up here, fixing one concern in #1102
@caendesilva
Copy link
Member Author

Maybe ['typeLabel']

classLabel may be better

@caendesilva caendesilva linked a pull request Feb 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant