Code

Refactor the breadcrumbs component#1122

Code

Merged

caendesilva merged 111 commits intomasterhydephp/develop:masterfrom refactor-breadcrumb-componenthydephp/develop:refactor-breadcrumb-componentCopy head branch name to clipboardFeb 26, 2023

+377

Commits

Commits on Feb 26, 2023

• Adding breadcrumb component.

  

  rgasch

  authored and

  caendesilva

  committed
  5aa1f9a

  Copy full SHA for 5aa1f9a

• Apply fixes from StyleCI

  StyleCIBot

  committed
  25e1b3a

  Copy full SHA for 25e1b3a

• Add public $breadcrumbs array to view component

  caendesilva

  committed
  c9f89bd

  Copy full SHA for c9f89bd

• Construct breadcrumbs in component class constructor instead of view

  caendesilva

  committed
  7b7d321

  Copy full SHA for 7b7d321

• Update registered view namespace to match implicit

  Show description for 27e22b5
  caendesilva

  committed
  27e22b5

  Copy full SHA for 27e22b5

• Move the getBreadcrumbs method from the Route model to view component

  caendesilva

  committed
  c8ecda4

  Copy full SHA for c8ecda4

• Protect the getBreadcrumbs method (accessible through public property)

  caendesilva

  committed
  b2ba95e

  Copy full SHA for b2ba95e

• Rename protected helper method

  caendesilva

  committed
  a6c4bc9

  Copy full SHA for a6c4bc9

• Pluralize BreadcrumbComponent class name to BreadcrumbsComponent

  caendesilva

  committed
  ce56bfc

  Copy full SHA for ce56bfc

• Pluralize breadcrumb view name to breadcrumbs

  caendesilva

  committed
  a0e9ef7

  Copy full SHA for a0e9ef7

• Create BreadcrumbsComponentTest.php

  caendesilva

  committed
  0bb6e69

  Copy full SHA for 0bb6e69

• Set up kernel and config for test class

  caendesilva

  committed
  4d5f939

  Copy full SHA for 4d5f939

• Add baseline test

  caendesilva

  committed
  84f1974

  Copy full SHA for 84f1974

• Clear resolved instance after test

  caendesilva

  committed
  90912b1

  Copy full SHA for 90912b1

• Add baseline rendering test

  caendesilva

  committed
  2f02792

  Copy full SHA for 2f02792

• Test the breadcrumb array generation

  caendesilva

  committed
  d88f8e7

  Copy full SHA for d88f8e7

• Apply fixes from StyleCI

  StyleCIBot

  committed
  952348c

  Copy full SHA for 952348c

• Close mocks at teardown

  caendesilva

  committed
  943333b

  Copy full SHA for 943333b

• Merge branch 'refactor-breadcrumb-component' of github.com:hydephp/develop into refactor-breadcrumb-component

  caendesilva

  committed
  4884d75

  Copy full SHA for 4884d75

• Refactor test to clear all resolved instances

  caendesilva

  committed
  1d91cc4

  Copy full SHA for 1d91cc4

• Resolve all bound instances

  caendesilva

  committed
  389e2bf

  Copy full SHA for 389e2bf

• Use CreatesApplication

  caendesilva

  committed
  5fcb4cc

  Copy full SHA for 5fcb4cc

• Add base method to test the rendered view contents

  caendesilva

  committed
  00da7be

  Copy full SHA for 00da7be

• Replace breadcrumb wrapper element div to be nav

  caendesilva

  committed
  38ab37e

  Copy full SHA for 38ab37e

• Add aria-label to the breadcrumb nav element

  caendesilva

  committed
  d849a1f

  Copy full SHA for d849a1f

• Remove empty class attribute

  caendesilva

  committed
  8cbd0ef

  Copy full SHA for 8cbd0ef

• Expect the labelled nav element

  caendesilva

  committed
  0467a17

  Copy full SHA for 0467a17

• Apply fixes from StyleCI

  StyleCIBot

  committed
  bb2e023

  Copy full SHA for bb2e023

• Revert "Use CreatesApplication"

  Show description for 4f10651
  caendesilva

  committed
  4f10651

  Copy full SHA for 4f10651

• Extract test requiring application to separate test

  caendesilva

  committed
  488e136

  Copy full SHA for 488e136

• Merge branch 'refactor-breadcrumb-component' of github.com:hydephp/develop into refactor-breadcrumb-component

  caendesilva

  committed
  65fbf61

  Copy full SHA for 65fbf61

• Apply fixes from StyleCI

  StyleCIBot

  committed
  86362ba

  Copy full SHA for 86362ba

• Test view on index page

  caendesilva

  committed
  f1c825f

  Copy full SHA for f1c825f

• Add testing helper to strip indentation and empty newlines

  caendesilva

  committed
  54884da

  Copy full SHA for 54884da

• Replace partial loop assertions with full comparison

  caendesilva

  committed
  be337c7

  Copy full SHA for be337c7

• Add tests covering a multitude of scenarios

  caendesilva

  committed
  d45381d

  Copy full SHA for d45381d

• Apply fixes from StyleCI

  Show description for 44edf49
  

  StyleCIBot

  authored and

  caendesilva

  committed
  44edf49

  Copy full SHA for 44edf49

• Render component within helper method

  caendesilva

  committed
  0cb2f02

  Copy full SHA for 0cb2f02

• Inline local testing variables

  caendesilva

  committed
  edc142c

  Copy full SHA for edc142c

• Format nowdocs

  caendesilva

  committed
  0bf07e7

  Copy full SHA for 0bf07e7

• Replace breadcrumb divider with single > symbol

  Show description for 5987168
  caendesilva

  committed
  5987168

  Copy full SHA for 5987168

• Wrap last breadcrumb entry in span element

  caendesilva

  committed
  20fd7e8

  Copy full SHA for 20fd7e8

• Add aria current attribute to last breadcrumb item

  caendesilva

  committed
  b0233d6

  Copy full SHA for b0233d6

• Change last breadcrumb item to be an anchor element

  Show description for 1e176a7
  caendesilva

  committed
  1e176a7

  Copy full SHA for 1e176a7

• Put breadcrumb items in an ordered list element

  caendesilva

  committed
  3771112

  Copy full SHA for 3771112

• Indent expected code

  caendesilva

  committed
  a540e9b

  Copy full SHA for a540e9b

• Supress unresolved file link inspections for test

  caendesilva

  committed
  2f157db

  Copy full SHA for 2f157db

• Apply fixes from StyleCI

  

  StyleCIBot

  authored and

  caendesilva

  committed
  db49a8a

  Copy full SHA for db49a8a

• Wrap each breadcrumb item in a list item element

  caendesilva

  committed
  e9ad773

  Copy full SHA for e9ad773

• Indent expected code

  caendesilva

  committed
  a372785

  Copy full SHA for a372785

• Format PHP code in Blade view

  caendesilva

  committed
  0b7fce1

  Copy full SHA for 0b7fce1

• Move to flex display since list items otherwise display horizontally

  caendesilva

  committed
  d918c68

  Copy full SHA for d918c68

• Put breadcrumb divider in a span element

  caendesilva

  committed
  561411b

  Copy full SHA for 561411b

• Add horizontal padding to the divider

  caendesilva

  committed
  9f4be63

  Copy full SHA for 9f4be63

• Add presentation role to remove dividers from the accessibility tree

  caendesilva

  committed
  c19e65c

  Copy full SHA for c19e65c

• Use aria-hidden instead of presentation role

  Show description for 8b8c640
  caendesilva

  committed
  8b8c640

  Copy full SHA for 8b8c640

• Update component to support attributes

  caendesilva

  committed
  3af8af5

  Copy full SHA for 3af8af5

• Merge in aria-label with the attributes

  Show description for a7c3ede
  caendesilva

  committed
  a7c3ede

  Copy full SHA for a7c3ede

• Test rendered Blade view with attributes

  caendesilva

  committed
  7e9eb4d

  Copy full SHA for 7e9eb4d

• Apply fixes from StyleCI

  

  StyleCIBot

  authored and

  caendesilva

  committed
  e183137

  Copy full SHA for e183137

• Expand abbreviated loop variable

  caendesilva

  committed
  38f7a14

  Copy full SHA for 38f7a14

• Extract testing helper for mocking the current page

  caendesilva

  committed
  44c3b76

  Copy full SHA for 44c3b76

• Mock the current page method as well

  caendesilva

  committed
  e3e54b4

  Copy full SHA for e3e54b4

• Format the path to a relative link so it can be properly resolved

  caendesilva

  committed
  e20758e

  Copy full SHA for e20758e

• Extract testing helper to mock the page

  caendesilva

  committed
  e3cb804

  Copy full SHA for e3cb804

• Expect relative links

  caendesilva

  committed
  8eb6e34

  Copy full SHA for 8eb6e34

• Update mocking test helper

  caendesilva

  committed
  25b686d

  Copy full SHA for 25b686d

• Debug test

  caendesilva

  committed
  c3ea080

  Copy full SHA for c3ea080

• Revert "Debug test"

  Show description for 2884f0d
  caendesilva

  committed
  2884f0d

  Copy full SHA for 2884f0d

• Set the page mocked page directly

  caendesilva

  committed
  a0810ea

  Copy full SHA for a0810ea

• Remove once from mock

  caendesilva

  committed
  3d577c6

  Copy full SHA for 3d577c6

• Attempt to get the home link from the index route

  Show description for 2502257
  caendesilva

  committed
  2502257

  Copy full SHA for 2502257

• Test with pretty URLs

  caendesilva

  committed
  2b5b23e

  Copy full SHA for 2b5b23e

• Suffix .html for pages (automatically removed when using pretty URLs)

  caendesilva

  committed
  9a59b12

  Copy full SHA for 9a59b12

• Update test annotation for renamed test

  caendesilva

  committed
  93c8d30

  Copy full SHA for 93c8d30

• Refactor unit test to extend unit test case (12.5x faster)

  caendesilva

  committed
  2ebfe54

  Copy full SHA for 2ebfe54

• Trim all index.html suffixes from URLs when pretty URLs are enabled

  caendesilva

  committed
  b971750

  Copy full SHA for b971750

• Replace index rewrite with falsy return to root destination

  caendesilva

  committed
  1d30bdb

  Copy full SHA for 1d30bdb

• Revert "Replace index rewrite with falsy return to root destination"

  Show description for fd62432
  caendesilva

  committed
  fd62432

  Copy full SHA for fd62432

• Replace '?:' with if

  caendesilva

  committed
  92f27a8

  Copy full SHA for 92f27a8

• Remove unnecessary parentheses

  caendesilva

  committed
  05fa93e

  Copy full SHA for 05fa93e

• Convert concatenation to string interpolation

  caendesilva

  committed
  333c9ed

  Copy full SHA for 333c9ed

• Rename loop variable

  caendesilva

  committed
  b91957e

  Copy full SHA for b91957e

• Test title generation

  caendesilva

  committed
  0352985

  Copy full SHA for 0352985

• Create title using the Hyde::makeTitle helper

  caendesilva

  committed
  00983d9

  Copy full SHA for 00983d9

• Snake case slugs are now supported

  Show description for c30c008
  caendesilva

  committed
  c30c008

  Copy full SHA for c30c008

• Inline simplified variable

  caendesilva

  committed
  627ff25

  Copy full SHA for 627ff25

• Use strict equality comparisons

  caendesilva

  committed
  a734f3c

  Copy full SHA for a734f3c

• Break instead of return as I think it's more semantically readable here

  caendesilva

  committed
  13eabdc

  Copy full SHA for 13eabdc

• Reset path reference at end of loop

  caendesilva

  committed
  2a0d38a

  Copy full SHA for 2a0d38a

• Append index.html for non-last items (removed when using pretty URLs)

  caendesilva

  committed
  8502272

  Copy full SHA for 8502272

• Replace Str chain to native function call

  caendesilva

  committed
  2f4cd80

  Copy full SHA for 2f4cd80

• Merge Str:of into single Str call

  caendesilva

  committed
  ba31c0c

  Copy full SHA for ba31c0c

• Buffer previous state in dedicated variable

  Show description for 789c249
  caendesilva

  committed
  789c249

  Copy full SHA for 789c249

• Convert concatenation to string interpolation

  caendesilva

  committed
  1506f8b

  Copy full SHA for 1506f8b

• Test with an incredibly nested page

  caendesilva

  committed
  b69ea86

  Copy full SHA for b69ea86

• Shift location of slash

  caendesilva

  committed
  6fffa6b

  Copy full SHA for 6fffa6b

• Revert "Shift location of slash"

  Show description for ff5aa4b
  caendesilva

  committed
  ff5aa4b

  Copy full SHA for ff5aa4b

• Apply fixes from StyleCI

  

  StyleCIBot

  authored and

  caendesilva

  committed
  32bcda1

  Copy full SHA for 32bcda1

• Revert "Convert concatenation to string interpolation"

  Show description for cfdb762
  caendesilva

  committed
  cfdb762

  Copy full SHA for cfdb762

• Format code

  caendesilva

  committed
  63ff8d0

  Copy full SHA for 63ff8d0

• Introduce local variables

  caendesilva

  committed
  dbde9c9

  Copy full SHA for dbde9c9

• Extract common parts from if statement

  caendesilva

  committed
  27f408e

  Copy full SHA for 27f408e

• Revert "Replace '?:' with if"

  Show description for 097c53b
  caendesilva

  committed
  097c53b

  Copy full SHA for 097c53b

• Revert "Introduce local variables"

  Show description for 81c5bd4
  caendesilva

  committed
  81c5bd4

  Copy full SHA for 81c5bd4

• Add newline

  caendesilva

  committed
  0923e4f

  Copy full SHA for 0923e4f

• Rename loop variable

  caendesilva

  committed
  9f909cf

  Copy full SHA for 9f909cf

• Remove unnecessary quotation marks

  caendesilva

  committed
  7c31194

  Copy full SHA for 7c31194

• Add code newline

  Show description for c6fa7c2
  caendesilva

  committed
  c6fa7c2

  Copy full SHA for c6fa7c2

• Merge branch 'master' into refactor-breadcrumb-component

  caendesilva

  committed
  ddcb1d5

  Copy full SHA for ddcb1d5

• Reorder imports

  caendesilva

  committed
  9c11d21

  Copy full SHA for 9c11d21