-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: Rename global properties #1243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending rename to `$route` as "current" is implied
Pending rename to `$routeKey` as "current" is implied, and it's not a page
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1317 2636 +1319
=============================================
Files 152 304 +152
Lines 3459 6922 +3463
=============================================
+ Hits 3459 6922 +3463
... and 152 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This reverts commit 2b3330e.
caendesilva
force-pushed
the
rename-global-properties
branch
from
March 10, 2023 12:37
0ecf127
to
dd9106c
Compare
caendesilva
force-pushed
the
rename-global-properties
branch
from
March 10, 2023 13:36
aef54de
to
15f6a9b
Compare
caendesilva
force-pushed
the
rename-global-properties
branch
from
March 10, 2023 13:43
4a7f311
to
2649ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully be the last breaking change. The old accessors are present but deprecated and will be removed before v1.0-proper. I think the RC break is justified here as since the properties are not documented I don't think many people use it so the impact is low, and the naming issue is quite severe. These are legacy properties introduced before route keys were a thing.
$currentRoute
variable will be renamed to$route
as "current" is implied$currentRoute
variable will be renamed to$routeKey
as "current" is implied, and it's not a page.For this, the location of the actual shared variables (in the ViewData) class are also deprecated, and updated for the renames. Most of these changes should be easy to upgrade with search+replace in project files.