Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HydePage::$title property readonly #1246

Merged
merged 3 commits into from
Mar 11, 2023

Conversation

caendesilva
Copy link
Member

Makes HydePage::$title property readonly as it does not support being persisted

Makes HydePage::$title property readonly as it does not support being persisted
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #1246 (b70acf7) into master (828e692) will not change coverage.
The diff coverage is n/a.

❗ Current head b70acf7 differs from pull request most recent head 897b635. Consider uploading reports for the commit 897b635 to get more accurate results

@@              Coverage Diff              @@
##              master     #1246     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1318      2636   +1318     
=============================================
  Files            152       304    +152     
  Lines           3461      6922   +3461     
=============================================
+ Hits            3461      6922   +3461     
Impacted Files Coverage Δ
packages/framework/src/Pages/Concerns/HydePage.php 100.00% <ø> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 11, 2023 14:05
@caendesilva caendesilva merged commit 00b2e74 into master Mar 11, 2023
@caendesilva caendesilva deleted the make-hydepage-title-property-readonly branch March 11, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant