Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test class references from main codebase #1287

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Conversation

caendesilva
Copy link
Member

We've had a lot of links to test classes, which has been useful for the rapid development, but look pretty ugly in the actual downstream code. This PR removes them.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1287 (584b33f) into master (251e042) will not change coverage.
The diff coverage is n/a.

❗ Current head 584b33f differs from pull request most recent head 287f54f. Consider uploading reports for the commit 287f54f to get more accurate results

@@              Coverage Diff              @@
##              master     #1287     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1316      2632   +1316     
=============================================
  Files            152       304    +152     
  Lines           3451      6902   +3451     
=============================================
+ Hits            3451      6902   +3451     
Impacted Files Coverage Δ
...ework/src/Console/Commands/BuildRssFeedCommand.php 100.00% <ø> (ø)
...mework/src/Console/Commands/BuildSearchCommand.php 100.00% <ø> (ø)
...ramework/src/Console/Commands/BuildSiteCommand.php 100.00% <ø> (ø)
...ework/src/Console/Commands/BuildSitemapCommand.php 100.00% <ø> (ø)
.../Console/Commands/ChangeSourceDirectoryCommand.php 100.00% <ø> (ø)
...framework/src/Console/Commands/MakePageCommand.php 100.00% <ø> (ø)
...rk/src/Console/Commands/PackageDiscoverCommand.php 100.00% <ø> (ø)
...ork/src/Console/Commands/PublishConfigsCommand.php 100.00% <ø> (ø)
...rk/src/Console/Commands/PublishHomepageCommand.php 100.00% <ø> (ø)
...ework/src/Console/Commands/PublishViewsCommand.php 100.00% <ø> (ø)
... and 64 more

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 14, 2023 15:54
@caendesilva caendesilva merged commit 5b5ae46 into master Mar 14, 2023
@caendesilva caendesilva deleted the remove-test-links branch March 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants