Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type and IDE support #1306

Merged
merged 77 commits into from
Mar 17, 2023
Merged

Improve type and IDE support #1306

merged 77 commits into from
Mar 17, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Mar 15, 2023

Increases type coverage from 98.25% to 99.25% by adding type annotations, generics, and type casts. This not only improves type coverage but also provides better IDE support and may eliminate type related bugs.

Class Start End
PostAuthor 90.48% 100%
ConsoleKernel 92.31% 100%
BuildWarnings 91.67% 95.74%
PageCollection 93.10% 96.55%
RssFeedGenerator 93.33% 99.35%
LoadConfiguration 93.62% 95.74%
DocumentationSearchPage 93.33% 100%
Total 98.25% 99.25%

Note that more classes than this are improved, I just haven't noted them in the table.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1306 (343fb43) into master (274e82c) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master     #1306     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1326      2654   +1328     
=============================================
  Files            152       304    +152     
  Lines           3465      6936   +3471     
=============================================
+ Hits            3465      6936   +3471     
Impacted Files Coverage Δ
...framework/src/Foundation/Kernel/FileCollection.php 100.00% <ø> (ø)
...framework/src/Foundation/Kernel/PageCollection.php 100.00% <ø> (ø)
...ramework/src/Foundation/Kernel/RouteCollection.php 100.00% <ø> (ø)
...Concerns/Internal/ForwardsIlluminateFilesystem.php 100.00% <ø> (ø)
.../Framework/Features/Blogging/Models/PostAuthor.php 100.00% <ø> (ø)
...amework/Features/Navigation/BaseNavigationMenu.php 100.00% <ø> (ø)
...ckages/framework/src/Support/Models/RenderData.php 100.00% <ø> (ø)
...ackages/framework/src/Support/Models/RouteList.php 100.00% <ø> (ø)
...es/framework/src/Console/Commands/DebugCommand.php 100.00% <100.00%> (ø)
...ramework/src/Console/Commands/RouteListCommand.php 100.00% <100.00%> (ø)
... and 12 more

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

StyleCIBot and others added 26 commits March 15, 2023 18:24
Code is obvious as is, and is protected thus does not require further information
More readable code, canonical accessor logic, and better Psalm support (for some reason)
@caendesilva caendesilva marked this pull request as ready for review March 17, 2023 09:07
@caendesilva caendesilva merged commit 4dfe608 into master Mar 17, 2023
@caendesilva caendesilva deleted the improve-type-support branch March 17, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants