Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use the View facade instead of view function #1310

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

caendesilva
Copy link
Member

This gives better type support and is easier to mock and work with.

@caendesilva caendesilva force-pushed the use-the-view-facade-instead-of-view-function branch 2 times, most recently from 71f85e0 to 646b20c Compare March 16, 2023 15:34
This gives better type support and is easier to mock and work with.
@caendesilva caendesilva force-pushed the use-the-view-facade-instead-of-view-function branch from 3b89608 to b45bca1 Compare March 16, 2023 15:35
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1310 (3b89608) into master (287775a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3b89608 differs from pull request most recent head a117eef. Consider uploading reports for the commit a117eef to get more accurate results

@@             Coverage Diff             @@
##              master     #1310   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2646      2646           
===========================================
  Files            304       304           
  Lines           6918      6918           
===========================================
  Hits            6918      6918           
Impacted Files Coverage Δ
...res/Documentation/SemanticDocumentationArticle.php 100.00% <100.00%> (ø)
...ramework/Views/Components/BreadcrumbsComponent.php 100.00% <100.00%> (ø)
...k/src/Framework/Views/Components/LinkComponent.php 100.00% <100.00%> (ø)
...Markdown/Processing/CodeblockFilepathProcessor.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 16, 2023 16:05
@caendesilva caendesilva merged commit b31f3e3 into master Mar 16, 2023
@caendesilva caendesilva deleted the use-the-view-facade-instead-of-view-function branch March 16, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant