Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up page data factories #1312

Merged
merged 10 commits into from
Mar 16, 2023
Merged

Clean up page data factories #1312

merged 10 commits into from
Mar 16, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Mar 16, 2023

  • Changed: Cleaned up PageDataFactory, NavigationDataFactory, and BlogPostDataFactory internals for better type safety
  • Removed: Classes PageDataFactory, NavigationDataFactory, and BlogPostDataFactory no longer use the InteractsWithFrontMatter trait

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1312 (ad33723) into master (4b1ce1e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ad33723 differs from pull request most recent head 0a2eb6c. Consider uploading reports for the commit 0a2eb6c to get more accurate results

@@              Coverage Diff              @@
##              master     #1312     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1323      2648   +1325     
=============================================
  Files            152       304    +152     
  Lines           3459      6922   +3463     
=============================================
+ Hits            3459      6922   +3463     
Impacted Files Coverage Δ
.../src/Framework/Factories/NavigationDataFactory.php 100.00% <100.00%> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 16, 2023 17:09
@caendesilva caendesilva merged commit 274e82c into master Mar 16, 2023
@caendesilva caendesilva deleted the clean-up-page-data-factories branch March 16, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant