Update article excerpt component to use route helper method instead of legacy link formatter #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1317 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1328 2656 +1328
=============================================
Files 152 304 +152
Lines 3470 6940 +3470
=============================================
+ Hits 3470 6940 +3470 see 152 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I also ran a file check to ensure that we don't use the formatLink helper anywhere else in the Blade views. So this bug should be an isolated event. |
caendesilva
added a commit
to caendesilva/hyde-large-example-site
that referenced
this pull request
Mar 17, 2023
caendesilva
deleted the
update-article-excerpt-component-to-use-route-helper-method-instead-of-legacy-link-formatter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the blog post feed component was not working on nested pages due to incorrect link formatting. The issue was caused by the use of the legacy style of links in
article-excerpt.blade.php. The fix changes the link format to use$post->getRoute, which dynamically resolves relative paths.The change was made by replacing the following code:
This PR has been tested and verified to resolve the issue. This fixes #1316