Fix nested index pages not showing in navigation #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1328 2658 +1330
=============================================
Files 152 304 +152
Lines 3470 6942 +3472
=============================================
+ Hits 3470 6942 +3472
... and 152 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
changed the title
caendesilva
added a commit
to caendesilva/hyde-large-example-site
that referenced
this pull request
Mar 17, 2023
caendesilva
deleted the
fix-nested-index-pages-not-showing-in-navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check in the navigation data factory so that a page like
_pages/posts/index.mdis considered internally as_pages/posts.md, as I think that closest matches the served site. This means this case is excluded from the default "hidden" setting for nested pages, but I think this better follows the principle of least astonishment since the page does not appear to be nested the same way, from a user's perspective. Fixes #1318