Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FeaturedImage class to only make API calls when not disabled #1321

Merged

Conversation

caendesilva
Copy link
Member

Fixes #1320

@caendesilva caendesilva force-pushed the fix-rss-feed-generator-not-respecting-the-no-api-flag branch from 5960cb9 to 3bb53e1 Compare March 17, 2023 20:45
@caendesilva caendesilva marked this pull request as ready for review March 17, 2023 20:47
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #1321 (5960cb9) into master (481eda1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5960cb9 differs from pull request most recent head 2df51ca. Consider uploading reports for the commit 2df51ca to get more accurate results

@@              Coverage Diff              @@
##              master     #1321     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1329      2662   +1333     
=============================================
  Files            152       304    +152     
  Lines           3471      6944   +3473     
=============================================
+ Hits            3471      6944   +3473     
Impacted Files Coverage Δ
...amework/Features/Blogging/Models/FeaturedImage.php 100.00% <100.00%> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 6ba776d into master Mar 17, 2023
@caendesilva caendesilva deleted the fix-rss-feed-generator-not-respecting-the-no-api-flag branch March 17, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The RSS feed generator does not respect the --no-api flag when getting content length for remote images
1 participant