Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "whitespace-nowrap" class to dropdown list item and align it right #1325

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Mar 18, 2023

Fixes #1324, but requires a minor patch? HydeFront bump.

Now looks like this:
image

But we probably need to offset it left: Edit: done,
image

Fixes #1324, but requires a minor HydeFront bump.
@caendesilva caendesilva linked an issue Mar 18, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #1325 (fe0f9fe) into master (05b62c2) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              master     #1325     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1331      2662   +1331     
=============================================
  Files            152       304    +152     
  Lines           3472      6944   +3472     
=============================================
+ Hits            3472      6944   +3472     

see 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva changed the title Add "whitespace-nowrap" class to dropdown list item Add "whitespace-nowrap" class to dropdown list item and align it right Mar 18, 2023
@caendesilva caendesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2023
@caendesilva caendesilva marked this pull request as ready for review March 18, 2023 10:53
@caendesilva caendesilva merged commit f0dca12 into master Mar 18, 2023
@caendesilva caendesilva deleted the fix-navigation-dropdowns-wrapping-over-multiple-lines branch March 18, 2023 10:55
@caendesilva caendesilva removed the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation dropdowns should not wrap over multiple lines
1 participant