Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AssetService::injectTailwindConfig method to handle missing config file gracefully #1327

Conversation

caendesilva
Copy link
Member

Fixes #1326

@caendesilva caendesilva marked this pull request as ready for review March 18, 2023 11:01
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #1327 (6b293c3) into master (f0dca12) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master     #1327     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1331      2664   +1333     
=============================================
  Files            152       304    +152     
  Lines           3472      6948   +3476     
=============================================
+ Hits            3472      6948   +3476     
Impacted Files Coverage Δ
.../framework/src/Framework/Services/AssetService.php 100.00% <100.00%> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit ea035f1 into master Mar 18, 2023
@caendesilva caendesilva deleted the update-playcdn-integration-to-work-gracefully-when-there-is-no-tailwind-config-file branch March 18, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlayCDN integration should work gracefully when there is no Tailwind config file
1 participant