Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close dropdown when clicking outside it or when pressing escape #1331

Merged
merged 3 commits into from
Mar 18, 2023

Conversation

caendesilva
Copy link
Member

Fixes #1330

@caendesilva caendesilva linked an issue Mar 18, 2023 that may be closed by this pull request
@caendesilva caendesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2023
@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #1331 (b8411ca) into master (29241c6) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master     #1331   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1332      1332           
===========================================
  Files            152       152           
  Lines           3474      3474           
===========================================
  Hits            3474      3474           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 18, 2023 18:01
@caendesilva caendesilva merged commit c056487 into master Mar 18, 2023
@caendesilva caendesilva deleted the improve-dropdown-closing-interactivity branch March 18, 2023 18:02
@caendesilva caendesilva removed the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking outside an activated dropdown should close it
1 participant