Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RealtimeCompiler option to not store rendered pages to disk #1334

Conversation

caendesilva
Copy link
Member

Adds a configuration option to view RealtimeCompiler pages without saving them to disk

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #1334 (3a3dc1f) into master (f780285) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              master     #1334     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1332      2664   +1332     
=============================================
  Files            152       304    +152     
  Lines           3474      6948   +3474     
=============================================
+ Hits            3474      6948   +3474     

see 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva added the WTD Calls What The Diff label Mar 18, 2023
@what-the-diff
Copy link

what-the-diff bot commented Mar 18, 2023

  • Added a new config option to the server section of hyde.php
  • Changed how index pages are rendered in DashboardController, if save_preview is true then we use StaticPageBuilder::handle() otherwise we compile it using Hyde::shareViewData($page) and $page->compile().
  • In PageRouter changed how html for a page is retrieved, if save_preview is true then we use StaticPageBuilder::handle() otherwise we compile it using Hyde::shareViewData($page) and $page->compile().

@caendesilva caendesilva marked this pull request as ready for review March 18, 2023 19:16
@caendesilva caendesilva merged commit e848c5f into master Mar 18, 2023
@caendesilva caendesilva deleted the add-realtime-compiler-option-to-not-store-rendered-pages-to-disk branch March 18, 2023 19:16
@caendesilva caendesilva removed the WTD Calls What The Diff label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant