Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotations in front matter class #1369

Merged
merged 3 commits into from
Apr 23, 2023

Conversation

caendesilva
Copy link
Member

Forgot to update the union type when was changed to return data instead of static

@caendesilva caendesilva marked this pull request as ready for review April 23, 2023 16:50
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #1369 (986c34c) into master (ea1b215) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #1369     +/-   ##
===========================================
  Coverage     99.97%   99.97%             
- Complexity     1339     2678   +1339     
===========================================
  Files           152      304    +152     
  Lines          3489     6978   +3489     
===========================================
+ Hits           3488     6976   +3488     
- Misses            1        2      +1     
Impacted Files Coverage Δ
...ages/framework/src/Markdown/Models/FrontMatter.php 100.00% <ø> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit 9797b89 into master Apr 23, 2023
@caendesilva caendesilva deleted the fix-front-matter-class-type-annotations branch April 23, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant