Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update realtime compiler dashboard configuration schema #1395

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

caendesilva
Copy link
Member

This moves the dashboard settings into an array. While this is a somewhat intrusive change, requiring user intervention due to the implicit deprecation, it helps make the configuration file cleaner by grouping semantically related elements. An added check makes sure to provide backwards compatibility with older configuration options.

The shortened editor/tips keys are not breaking, as they have not been released yet.

To upgrade, replace the following in config/hyde.php:

'server' => [
    // ...

    'enabled' => env('SERVER_DASHBOARD', true),
],

With this:

'server' => [
    // ...

    'dashboard' => [
        'enabled' => env('SERVER_DASHBOARD', true),
    ],
],

This moves the dashboard settings into an array. While this is a somewhat intrusive change, requiring user intervention due to the implicit deprecation, it helps make the configuration file cleaner by grouping semantically related elements. An added check makes sure to provide backwards compatibility with older configuration options.

The shortened editor/tips keys are not breaking, as they have not been released yet.
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1395 (45fffad) into master (28b18a9) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master    #1395     +/-   ##
===========================================
  Coverage     99.97%   99.97%             
- Complexity     1701     3402   +1701     
===========================================
  Files           180      360    +180     
  Lines          4609     9218   +4609     
===========================================
+ Hits           4608     9216   +4608     
- Misses            1        2      +1     

see 180 files with indirect coverage changes

@caendesilva caendesilva merged commit b563dc6 into master Oct 27, 2023
15 checks passed
@caendesilva caendesilva deleted the realtime-compiler-dashboard-improvements branch October 27, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant