Break down complex model factory helper method #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is quite complex due to it's many conditionals. Extracting helpers with describing names makes the code easier to read, maintain, and understand.
Codecov Report
@@ Coverage Diff @@
## master #1396 +/- ##
===========================================
Coverage 99.97% 99.97%
- Complexity 1701 3406 +1705
===========================================
Files 180 360 +180
Lines 4609 9230 +4621
===========================================
+ Hits 4608 9228 +4620
- Misses 1 2 +1
|
caendesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is quite complex due to it's many conditionals. Extracting helpers with describing names makes the code easier to read, maintain, and understand.