Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the featured image factory to specify the file causing an exception #1409

Merged
merged 4 commits into from
Oct 28, 2023

Conversation

caendesilva
Copy link
Member

We throw an exception when an image without a source is specified, but we don't mention which file. Now we do.

// Old
No featured image source was found
// New
No featured image source was found in "_posts/my-new-post.md"

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1409 (689db9c) into master (d5b24d8) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             master    #1409     +/-   ##
===========================================
  Coverage     99.97%   99.97%             
- Complexity     1705     3410   +1705     
===========================================
  Files           180      360    +180     
  Lines          4619     9240   +4621     
===========================================
+ Hits           4618     9238   +4620     
- Misses            1        2      +1     
Files Coverage Δ
...rk/src/Framework/Factories/BlogPostDataFactory.php 100.00% <100.00%> (ø)
...k/src/Framework/Factories/FeaturedImageFactory.php 100.00% <100.00%> (ø)

... and 180 files with indirect coverage changes

…thub.com:hydephp/develop into improve-featured-image-factory-exception-message
@caendesilva caendesilva merged commit 3980228 into master Oct 28, 2023
15 checks passed
@caendesilva caendesilva deleted the improve-featured-image-factory-exception-message branch October 28, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant