Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type coverage #1410

Merged
merged 23 commits into from
Oct 28, 2023
Merged

Improve type coverage #1410

merged 23 commits into from
Oct 28, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Oct 28, 2023

Brings up type coverage by another ~0.20%

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1410 (d03b7f0) into master (3980228) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d03b7f0 differs from pull request most recent head d8c09bd. Consider uploading reports for the commit d8c09bd to get more accurate results

@@             Coverage Diff             @@
##             master    #1410     +/-   ##
===========================================
  Coverage     99.97%   99.97%             
- Complexity     1705     3412   +1707     
===========================================
  Files           180      360    +180     
  Lines          4620     9254   +4634     
===========================================
+ Hits           4619     9252   +4633     
- Misses            1        2      +1     
Files Coverage Δ
...rk/src/Console/Commands/PublishHomepageCommand.php 100.00% <ø> (ø)
packages/framework/src/Facades/Filesystem.php 100.00% <ø> (ø)
...ges/framework/src/Foundation/Kernel/Filesystem.php 100.00% <100.00%> (ø)
...mework/src/Framework/Actions/BladeMatterParser.php 100.00% <100.00%> (ø)
...ework/Actions/PreBuildTasks/CleanSiteDirectory.php 100.00% <ø> (ø)
.../src/Framework/Factories/NavigationDataFactory.php 100.00% <ø> (ø)
...rk/src/Framework/Features/Metadata/MetadataBag.php 100.00% <100.00%> (ø)
.../Framework/Features/Navigation/DropdownNavItem.php 100.00% <100.00%> (ø)
...mework/src/Framework/Services/BuildTaskService.php 100.00% <100.00%> (ø)

... and 180 files with indirect coverage changes

@caendesilva caendesilva marked this pull request as ready for review October 28, 2023 17:59
@caendesilva caendesilva merged commit 68471d7 into master Oct 28, 2023
13 checks passed
@caendesilva caendesilva deleted the code-quality branch October 28, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant