Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General code quality cleanups #1411

Merged
merged 6 commits into from
Oct 28, 2023
Merged

General code quality cleanups #1411

merged 6 commits into from
Oct 28, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Oct 28, 2023

General cleanups and improvements. Nothing breaking. Also brings our code coverage back up to 100%.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1411 (f7a13bc) into master (68471d7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master     #1411      +/-   ##
=============================================
+ Coverage     99.97%   100.00%   +0.02%     
- Complexity     1706      3406    +1700     
=============================================
  Files           180       360     +180     
  Lines          4627      9252    +4625     
=============================================
+ Hits           4626      9252    +4626     
+ Misses            1         0       -1     
Files Coverage Δ
packages/framework/src/Facades/Config.php 100.00% <100.00%> (ø)
...rk/src/Framework/Features/Metadata/MetadataBag.php 100.00% <100.00%> (ø)

... and 181 files with indirect coverage changes

@caendesilva caendesilva marked this pull request as ready for review October 28, 2023 18:24
@caendesilva caendesilva merged commit c00dbf4 into master Oct 28, 2023
15 checks passed
@caendesilva caendesilva deleted the code-quality branch October 28, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant