Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update monorepo readme to use the develop branch for package test badges #1439

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

caendesilva
Copy link
Member

Since we don't merge to the downstream masters unless tests pass there is little point having the test badges there. Instead we want to know if something broke when pushing a change that is running in the downstream context.

Since we don't merge to the downstream masters unless tests pass there is little point having the test badges there. Instead we want to know if something broke when pushing a change that is running in the downstream context.
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1439 (4bb61ac) into master (82a166f) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              master     #1439     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1709      3418   +1709     
=============================================
  Files            180       360    +180     
  Lines           4642      9284   +4642     
=============================================
+ Hits            4642      9284   +4642     

see 180 files with indirect coverage changes

@caendesilva caendesilva marked this pull request as ready for review November 8, 2023 13:31
@caendesilva caendesilva merged commit 0be3136 into master Nov 8, 2023
19 checks passed
@caendesilva caendesilva deleted the update-monorepo-readme branch November 8, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant