Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command extending wrong base class #1453

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

caendesilva
Copy link
Member

Fixes a mistake in #1450

@caendesilva caendesilva marked this pull request as ready for review November 12, 2023 15:19
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #1453 (e2f9e8d) into master (01bc43f) will not change coverage.
The diff coverage is n/a.

❗ Current head e2f9e8d differs from pull request most recent head 451124b. Consider uploading reports for the commit 451124b to get more accurate results

@@              Coverage Diff              @@
##              master     #1453     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1728      3456   +1728     
=============================================
  Files            180       360    +180     
  Lines           4693      9386   +4693     
=============================================
+ Hits            4693      9386   +4693     
Files Coverage Δ
...es/framework/src/Console/Commands/ServeCommand.php 100.00% <ø> (ø)

... and 180 files with indirect coverage changes

@caendesilva caendesilva merged commit ddd0c75 into master Nov 12, 2023
17 checks passed
@caendesilva caendesilva deleted the pass-through-settings-to-realtime-compiler branch November 12, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant