-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a live edit feature to the realtime compiler #1458
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to inject code before serving but without it affecting any compiled source saved to disk
caendesilva
force-pushed
the
realtime-compiler-live-edit
branch
from
November 13, 2023 18:00
253d8f9
to
2d6647e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1458 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 3456 3456
===========================================
Files 360 360
Lines 9386 9386
===========================================
Hits 9386 9386 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
realtime-compiler-live-edit
branch
from
November 13, 2023 19:52
d407bb4
to
6b42303
Compare
Replaces the copy with actual DOM element we can interact with
This reverts commit d0e8a7e.
This reverts commit ba64ab4.
The custom JavaScript solution adds little value, so I prefer to let the browser handle these things. If a validation error occurs, the exception will render.
This reverts commit 4411be9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live edit
Usage
The live edit feature allows you to quickly edit Markdown-based pages (posts, docs, and pages) directly in the browser.
To enter the live editor, simply double-click on the article you want to edit, and it will be replaced with a text editor.
When you're done, click the save button to save the changes to the page's source file.
Shortcuts
The live editor supports the following keyboard shortcuts:
Ctrl + E
- Enter/Exit editorCtrl + S
- Save changesesc
- Exit editor if activeConfiguration
The live editor can be disabled in the
config/hyde.php
file.The live editor plugin code will not be saved to your static site.