Make heading permalink hashes hidden when not hovered #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix a bug where crawlers like Google Bot thinks this is a part of the heading, leading to it being visible in search results.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1519 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1740 3480 +1740
=============================================
Files 180 360 +180
Lines 4715 9430 +4715
=============================================
+ Hits 4715 9430 +4715 ☔ View full report in Codecov by Sentry. |
|
Nope, this just breaks heading permalinks, and has no effect on Google indexing. |
caendesilva
added a commit
that referenced
this pull request
Jul 8, 2024
This reverts commit f8106c8. See #1519 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix a bug where crawlers like Google Bot thinks this is a part of the heading, leading to it being visible in search results.
Adding
display: hiddenwould likely solve this, but that breaks the transition. Using visibility modifiers should work the same, but retain the existing visual behaviour.