[2.x] Change NavItem class API to be fluent instead of readonly #1574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of HydePHP v2.x via #1568
A breaking change here is that the NavItem properties are no longer public. Instead they must be used through (already existing) accessors. While this adds extra boilerplate and inconvenience, it also allows us to open up the class data to being edited, the reason we protect the properties is so that we can control the data being added for a consistent and predictable state.
How to upgrade:
Simply replace any usage where you manually called a property with its accessor. (see the file diff for an example)