Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and add more view tests #1589

Merged
merged 5 commits into from
Feb 25, 2024
Merged

Improve and add more view tests #1589

merged 5 commits into from
Feb 25, 2024

Conversation

caendesilva
Copy link
Member

Adds some testing helpers and a new test. This PR is considered internal since it only affects the test suite and no public code.

@caendesilva caendesilva force-pushed the improved-view-testing branch from 2a5c9fc to 4fea894 Compare February 25, 2024 11:00
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1ec4ca5) to head (f282751).

Additional details and impacted files
@@              Coverage Diff              @@
##              master     #1589     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1746      3492   +1746     
=============================================
  Files            180       360    +180     
  Lines           4723      9446   +4723     
=============================================
+ Hits            4723      9446   +4723     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the improved-view-testing branch from 5284b86 to f282751 Compare February 25, 2024 11:11
@caendesilva caendesilva marked this pull request as ready for review February 25, 2024 11:14
@caendesilva caendesilva merged commit 843f461 into master Feb 25, 2024
19 checks passed
@caendesilva caendesilva deleted the improved-view-testing branch February 25, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant