Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Always place navigation menu items in dropdowns when set in front matter #1597

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Feb 28, 2024

Makes so that the generator always place navigation menu items in dropdowns when set in front matter, regardless of subdirectory group config.

@caendesilva caendesilva force-pushed the refactor-main-menu-generation-to-be-deterministic branch from e355274 to 080d204 Compare February 28, 2024 10:15
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (e2b14c9) to head (353603b).

Additional details and impacted files
@@                       Coverage Diff                        @@
##             improved-navigation-internals    #1597   +/-   ##
================================================================
  Coverage                            99.95%   99.95%           
  Complexity                            1774     1774           
================================================================
  Files                                  183      183           
  Lines                                 4796     4796           
================================================================
  Hits                                  4794     4794           
  Misses                                   2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva marked this pull request as ready for review February 28, 2024 12:00
@caendesilva caendesilva changed the title [2.x] Refactor main menu generation to be deterministic [2.x] Always place navigation menu items in dropdowns when set in front matter Feb 28, 2024
@caendesilva caendesilva merged commit 5eb64a1 into improved-navigation-internals Feb 28, 2024
7 checks passed
@caendesilva caendesilva deleted the refactor-main-menu-generation-to-be-deterministic branch February 28, 2024 12:02
caendesilva added a commit that referenced this pull request Feb 28, 2024
@caendesilva caendesilva mentioned this pull request Jun 27, 2024
99 tasks
@caendesilva caendesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant