-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Simplify navigation item group state handling to be deterministic #1632
[2.x] Simplify navigation item group state handling to be deterministic #1632
Conversation
Want to move away from depending so much on the keys
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1632 +/- ##
===================================================================
- Coverage 99.85% 99.85% -0.01%
- Complexity 1782 1783 +1
===================================================================
Files 185 185
Lines 4814 4812 -2
===================================================================
- Hits 4807 4805 -2
Misses 7 7 ☔ View full report in Codecov by Sentry. |
Tests are failing because of how the unit tests are set up. Deterministically discovering which group is active means that the groups actually need to be present in the kernel, just mocking the current page is not enough. See dc4a539 |
d42416a
to
7161f0b
Compare
This is temporary as I want to visualise how the data is passed here for the refactor
This reverts commit 3938201.
Apparently some tests use other pages, and I think that's fine for now
8a2e460
to
2f8b7cc
Compare
10b9797
to
5b51089
Compare
5c9a917
to
d0ef005
Compare
Performance consideration is negligible (new is 0.038ms instead of 0.085ms) but it makes it more understandable and reduces the need of a complex loop
24d7e2e
to
c860213
Compare
Targets #1568