[2.x] Simplify the navigation items class #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1637 +/- ##
===================================================================
+ Coverage 99.87% 99.93% +0.06%
+ Complexity 1787 1779 -8
===================================================================
Files 185 184 -1
Lines 4816 4802 -14
===================================================================
- Hits 4810 4799 -11
+ Misses 6 3 -3 ☔ View full report in Codecov by Sentry. |
And to care less about the route state
caendesilva
force-pushed
the
simplify-the-navigation-items-class
branch
from
67066be to
6aa82b7
Compare
caendesilva
force-pushed
the
simplify-the-navigation-items-class
branch
from
09ae1b2 to
b4011e1
Compare
Use `$item->getPage()->getRoute()` instead
caendesilva
force-pushed
the
simplify-the-navigation-items-class
branch
from
4c33e65 to
1b94a90
Compare
caendesilva
force-pushed
the
simplify-the-navigation-items-class
branch
from
b673978 to
37c51c2
Compare
Turns out we really didn't need this. It does add one test for the new side effect of constructor now being less magic (desirable as it's the scope of the create method)
Now longer needed as we decoupled the navigation group class
caendesilva
force-pushed
the
simplify-the-navigation-items-class
branch
from
09938c8 to
3e4901b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #1568 and further simplifies the navigation internals. It inlines the added navigation destination class and simplifies the navigation item class so it is now at the point where I can't find anything else to remove, signaling it has reached perfection.