Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Remove the NavigationElement contract #1640

Conversation

caendesilva
Copy link
Member

This was probably overengineered considering how little it's used after simplifying the code

Targets #1568

Verified

This commit was signed with the committer’s verified signature.
caendesilva Caen De Silva

Verified

This commit was signed with the committer’s verified signature.
caendesilva Caen De Silva
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (67c5d1d) to head (4385cc7).

Additional details and impacted files
@@                       Coverage Diff                        @@
##             improved-navigation-internals    #1640   +/-   ##
================================================================
  Coverage                            99.93%   99.93%           
  Complexity                            1778     1778           
================================================================
  Files                                  184      184           
  Lines                                 4799     4799           
================================================================
  Hits                                  4796     4796           
  Misses                                   3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
caendesilva Caen De Silva
@caendesilva caendesilva force-pushed the remove-the-navigation-element-contract branch from 77f9a73 to 9b1a1d0 Compare March 25, 2024 09:14

Verified

This commit was signed with the committer’s verified signature.
caendesilva Caen De Silva
@caendesilva caendesilva marked this pull request as ready for review March 25, 2024 09:25
@caendesilva caendesilva merged commit b09400a into improved-navigation-internals Mar 25, 2024
8 checks passed
@caendesilva caendesilva deleted the remove-the-navigation-element-contract branch March 25, 2024 09:26
@caendesilva caendesilva mentioned this pull request Jun 27, 2024
99 tasks
@caendesilva caendesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant