Improve the codebase using the new Feature enum #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
improve-codebase-by-using-the-new-feature-enum
branch
from
e4094e7 to
ac9a6a0
Compare
caendesilva
force-pushed
the
improve-codebase-by-using-the-new-feature-enum
branch
from
ac9a6a0 to
085cc1d
Compare
We don't use this anywhere but a test, so no reason to have it. It also lets us remove the null type.
caendesilva
force-pushed
the
improve-codebase-by-using-the-new-feature-enum
branch
from
cc664ea to
3ae0e24
Compare
This reverts commit 8329400.
caendesilva
force-pushed
the
improve-codebase-by-using-the-new-feature-enum
branch
from
956f5e4 to
88e9866
Compare
Update features toArray representation to use camelCase instead of kebab-case to match other arrayable formats, like in the HydeKernel.
…ions" This reverts commit df37cce as it may be out of scope for this PR. Consider instead enforcing a common convention in v2.
This does not add any new information
This was referenced Apr 12, 2024
caendesilva
added a commit
that referenced
this pull request
Apr 13, 2024
Fixes an issue introduced in #1652
caendesilva
pushed a commit
to hydephp/framework
that referenced
this pull request
Apr 13, 2024
Fixes an issue introduced in hydephp/develop#1652 hydephp/develop@3189eb3
caendesilva
pushed a commit
to hydephp/framework
that referenced
this pull request
Apr 13, 2024
Fixes an issue introduced in hydephp/develop#1652 hydephp/develop@3189eb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizes the enum added in #1650 to improve the codebase and makes it easier to increase its adoption. It also cherry picks some changes from #1651
It also deprecates passing a string to the
HydeKernel::hasFeature()method and doing so will trigger a deprecation and build warning: