Clean up and refactor code #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should have the same results
caendesilva
force-pushed
the
code-cleanup
branch
from
e68487e to
f4e4da4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1663 +/- ##
============================================
+ Coverage 99.63% 99.97% +0.34%
+ Complexity 1754 1742 -12
============================================
Files 182 182
Lines 4687 4667 -20
============================================
- Hits 4670 4666 -4
+ Misses 17 1 -16 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
code-cleanup
branch
from
2e16462 to
9dd43c9
Compare
caendesilva
force-pushed
the
code-cleanup
branch
from
40d1f15 to
db5a0ea
Compare
This reverts commit 8ce37cb.
We're not doing any filtering so we should not need to reset anything
I think this will properly fix the Psalm type issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor code cleanup and refactors, mainly for tests. Goes through almost all tests to ensure they are properly formatted and use the best assertions. Some of these are over two years old (AKA the first tests of HydePHP) and in need of some care. It also fixes over 30 Psalm issues and increases the type coverage to as much as we're gonna be able to get it.