Move internal helper classes to new internal support namespace #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By placing experimental or internal classes within a dedicated namespace like Hyde\Support\Internal, we make it clear to other developers that these classes are not part of the stable public API. It also allows us to organize our codebase more effectively, making it easier to maintain and evolve over time. It also gives us more freedom to create more helper classes like this, without increasing the maintenance burden.
caendesilva
force-pushed
the
refactor-to-move-internal-code-to-internal-namespace
branch
from
2e041cf to
78e9b0d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1678 +/- ##
=========================================
Coverage 99.97% 99.97%
Complexity 1743 1743
=========================================
Files 182 182
Lines 4669 4669
=========================================
Hits 4668 4668
Misses 1 1 ☔ View full report in Codecov by Sentry. |
caendesilva
deleted the
refactor-to-move-internal-code-to-internal-namespace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By placing experimental or internal classes within a dedicated namespace like Hyde\Support\Internal, we make it clear to other developers that these classes are not part of the stable public API. It also allows us to organize our codebase more effectively, making it easier to maintain and evolve over time. It also gives us more freedom to create more helper classes like this, without increasing the maintenance burden.