-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update realtime compiler open flag to support specifying the page to open #1694
Merged
caendesilva
merged 15 commits into
master
from
update-realtime-compiler-open-flag-to-support-specifying-the-page-to-open
Apr 28, 2024
Merged
Update realtime compiler open flag to support specifying the page to open #1694
caendesilva
merged 15 commits into
master
from
update-realtime-compiler-open-flag-to-support-specifying-the-page-to-open
Apr 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
=========================================
Coverage 99.97% 99.97%
Complexity 1744 1744
=========================================
Files 181 181
Lines 4661 4663 +2
=========================================
+ Hits 4660 4662 +2
Misses 1 1 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
update-realtime-compiler-open-flag-to-support-specifying-the-page-to-open
branch
from
April 28, 2024 13:14
6a3dd9e
to
ae0d5bb
Compare
caendesilva
force-pushed
the
update-realtime-compiler-open-flag-to-support-specifying-the-page-to-open
branch
from
April 28, 2024 13:16
e6d9793
to
885a24e
Compare
caendesilva
deleted the
update-realtime-compiler-open-flag-to-support-specifying-the-page-to-open
branch
April 28, 2024 13:44
This was referenced Jun 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
This pull request aims to enhance the functionality of the new realtime compiler by introducing a
--open
flag. With this addition, users will have the ability to specify the page to open upon server startup. The default page will remain as 'index', ensuring backward compatibility, while the--open
flag offers users the flexibility to easily navigate to a different page.Example Usage:
Executing the command above will result in the server opening
localhost:8080/dashboard
instead of the defaultlocalhost:8080
. This feature enhancement aims to streamline user experience by providing a convenient method to set the initial page when launching the server.It fixes #1504