Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update realtime compiler open flag to support specifying the page to open #1694

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Apr 26, 2024

Pull Request Description:

This pull request aims to enhance the functionality of the new realtime compiler by introducing a --open flag. With this addition, users will have the ability to specify the page to open upon server startup. The default page will remain as 'index', ensuring backward compatibility, while the --open flag offers users the flexibility to easily navigate to a different page.

Example Usage:

php hyde serve --open=dashboard

Executing the command above will result in the server opening localhost:8080/dashboard instead of the default localhost:8080. This feature enhancement aims to streamline user experience by providing a convenient method to set the initial page when launching the server.

It fixes #1504

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (39fe441) to head (bcfd573).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1694   +/-   ##
=========================================
  Coverage     99.97%   99.97%           
  Complexity     1744     1744           
=========================================
  Files           181      181           
  Lines          4661     4663    +2     
=========================================
+ Hits           4660     4662    +2     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the update-realtime-compiler-open-flag-to-support-specifying-the-page-to-open branch from 6a3dd9e to ae0d5bb Compare April 28, 2024 13:14
@caendesilva caendesilva force-pushed the update-realtime-compiler-open-flag-to-support-specifying-the-page-to-open branch from e6d9793 to 885a24e Compare April 28, 2024 13:16
@caendesilva caendesilva marked this pull request as ready for review April 28, 2024 13:44
@caendesilva caendesilva merged commit e86b33f into master Apr 28, 2024
21 checks passed
@caendesilva caendesilva deleted the update-realtime-compiler-open-flag-to-support-specifying-the-page-to-open branch April 28, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update realtime compiler open flag to support specifying the page to open
1 participant