Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Refactor filesystem helpers #1698

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Apr 29, 2024

Changes here can now be cherry picked to master as none of these are breaking, as only the implementations are refactored, but none of the APIs.

@caendesilva caendesilva force-pushed the refactor-filesystem-helpers branch from 31bdc91 to 2872b8e Compare April 29, 2024 12:21
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (88e3c5e) to head (2872b8e).

❗ Current head 2872b8e differs from pull request most recent head d520dc0. Consider uploading reports for the commit d520dc0 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             2.x-dev    #1698      +/-   ##
=============================================
- Coverage      99.97%   99.97%   -0.01%     
+ Complexity      1773     1769       -4     
=============================================
  Files            183      183              
  Lines           4714     4706       -8     
=============================================
- Hits            4713     4705       -8     
  Misses             1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva marked this pull request as ready for review April 29, 2024 12:27
@caendesilva caendesilva merged commit 3d348c9 into 2.x-dev Apr 29, 2024
8 checks passed
@caendesilva caendesilva deleted the refactor-filesystem-helpers branch April 29, 2024 12:28
caendesilva added a commit that referenced this pull request Apr 29, 2024
@caendesilva caendesilva mentioned this pull request Jun 27, 2024
99 tasks
@caendesilva caendesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant