Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use late static bindings to support overriding data collections file finding #1717

Merged

Conversation

caendesilva
Copy link
Member

Fixes #1716 by calling static instead of the class self reference.

This fix can be released in a patch release since protected methods are generally not supported by our BC promise.

@caendesilva caendesilva linked an issue Jun 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (00943e3) to head (5b01fe4).
Report is 4 commits behind head on master.

Current head 5b01fe4 differs from pull request most recent head 38f938c

Please upload reports for the commit 38f938c to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1717   +/-   ##
=========================================
  Coverage     99.97%   99.97%           
  Complexity     1745     1745           
=========================================
  Files           181      181           
  Lines          4661     4661           
=========================================
  Hits           4660     4660           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva merged commit 712f93f into master Jun 8, 2024
20 checks passed
@caendesilva caendesilva deleted the fix-datacollections-file-finding-method-cant-be-overriden branch June 8, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataCollections file finding method can't be overriden
1 participant