Code

[2.x] Includes facade improvements#1738

Code

Merged

caendesilva merged 105 commits into2.x-devhydephp/develop:2.x-devfrom includes-facade-improvementshydephp/develop:includes-facade-improvementsCopy head branch name to clipboardJun 26, 2024

+511-50

Commits

Commits on Jun 26, 2024

• Extract helper method

  caendesilva

  committed
  25733a1

• Get file contents using filesystem facade

  caendesilva

  committed
  2da4e75

• Get file existence using filesystem facade

  caendesilva

  committed
  2df07d5

• Create IncludesFacadeUnitTest.php

  caendesilva

  committed
  3a73736

• Add test crosslinks

  caendesilva

  committed
  dfc5581

• Generate unit test with GPT 4

  caendesilva

  committed
  48180bc

• Test needs kernel

  caendesilva

  committed
  8a776ef

• Clean up formatting

  caendesilva

  committed
  b117a37

• Use mockable get instead of get contents

  caendesilva

  committed
  d66537d

• Revert "Use mockable get instead of get contents"

  Show description for 85314bf
  caendesilva

  committed
  85314bf

• Reapply "Use mockable get instead of get contents"

  Show description for 37e7ddd
  caendesilva

  committed
  37e7ddd

• Use Illuminate filesystem

  caendesilva

  committed
  84a6d93

• Don't mock Markdown class

  caendesilva

  committed
  a216620

• Add missing assertions

  caendesilva

  committed
  5bcb54d

• Clear resolved Blade instances

  caendesilva

  committed
  bfa129c

• Revert "Clear resolved Blade instances"

  Show description for 6288483
  caendesilva

  committed
  6288483

• Remove Blade mocks

  caendesilva

  committed
  852cb99

• Revert "Remove Blade mocks"

  Show description for 60c2134
  caendesilva

  committed
  60c2134

• Swap Blade for a mock

  caendesilva

  committed
  bd04137

• Refactor to extract helper method

  caendesilva

  committed
  2661b8e

• Refactor with GPT 4 to use the added helper method

  caendesilva

  committed
  d950c90

• Move variable assignments inside closures

  caendesilva

  committed
  5e7869f

• Refactor to move Blade mocks into closure

  caendesilva

  committed
  4868497

• Cleanup formatting

  caendesilva

  committed
  45e59ce

• Add broader level feature test

  caendesilva

  committed
  2658708

• Specify page class to use the custom Markdown features

  caendesilva

  committed
  9f6a579

• Change page class used to render Markdown partials to MarkdownDocument

  Show description for f15bea8
  caendesilva

  committed
  f15bea8

• Add test for current state

  caendesilva

  committed
  9a8538c

• Do not inject Torchlight attribution for included partials

  Show description for 83c6136
  caendesilva

  committed
  83c6136

• Clean up formatting

  caendesilva

  committed
  e56494d

• Move up test in source

  caendesilva

  committed
  9d4a85b

• Update RELEASE_NOTES.md

  caendesilva

  committed
  0225edd

• Extract helper method

  caendesilva

  committed
  b7a7a79

• Test advanced Blade partial is compiled to HTML

  caendesilva

  committed
  5c1833e

• Remove link include requiring more setup

  caendesilva

  committed
  0127802

• Clean up whitespace

  caendesilva

  committed
  1d25d01

• Test includes usage from Blade view

  Show description for ffc8e7d
  caendesilva

  committed
  ffc8e7d

• Test without extensions

  caendesilva

  committed
  b642920

• Add element to match others

  caendesilva

  committed
  f6d9755

• Clarify the test data

  caendesilva

  committed
  b207e9b

• Reorder lines

  caendesilva

  committed
  2d8a349

• Document the associated PR

  caendesilva

  committed
  1365f1c

• Trim trailing whitespace from included Markdown

  Show description for 9cc70f6
  caendesilva

  committed
  9cc70f6

• Clarify how the test works

  caendesilva

  committed
  eeb1fe4

• Add cases for the current escape state

  caendesilva

  committed
  e9b877a

• Extra comment clarification

  caendesilva

  committed
  6f656e4

• Update Includes helpers to return HtmlString objects

  Show description for cc33174
  caendesilva

  committed
  cc33174

• Replace ternary expression with if/else block

  caendesilva

  committed
  c527e97

• Introduce local variables

  caendesilva

  committed
  4d44b83

• Wrap declaration in else block

  caendesilva

  committed
  2282b8e

• Unwrap common parts of if/else block

  caendesilva

  committed
  1e1520a

• Unwrap 'else'

  caendesilva

  committed
  370524a

• Invert control flow to simply conditional paths

  caendesilva

  committed
  667f7d9

• Move out return from condition

  caendesilva

  committed
  6cd529f

• Merge into 'elseif'

  caendesilva

  committed
  130dd77

• Revert "Merge into 'elseif'"

  Show description for d0d6709
  caendesilva

  committed
  d0d6709

• Revert "Move out return from condition"

  Show description for d248f04
  caendesilva

  committed
  d248f04

• Revert "Invert control flow to simply conditional paths"

  Show description for dc7c75c
  caendesilva

  committed
  dc7c75c

• Revert "Unwrap 'else'"

  Show description for 012a91d
  caendesilva

  committed
  012a91d

• Revert "Unwrap common parts of if/else block"

  Show description for de5131e
  caendesilva

  committed
  de5131e

• Revert "Wrap declaration in else block"

  Show description for 59448a6
  caendesilva

  committed
  59448a6

• Revert "Introduce local variables"

  Show description for fc6460d
  caendesilva

  committed
  fc6460d

• Revert "Replace ternary expression with if/else block"

  Show description for 80e6e1e
  caendesilva

  committed
  80e6e1e

• Extract helper method to render Markdown

  caendesilva

  committed
  66ced70

• Extract helper method to render Blade

  caendesilva

  committed
  b923262

• Extract helper method to render Html

  Show description for 8d7b1cb
  caendesilva

  committed
  8d7b1cb

• Refactor control flow

  caendesilva

  committed
  9038ab0

• Unwrap 'else'

  caendesilva

  committed
  e120ba3

• Revert "Unwrap 'else'"

  Show description for c0efe45
  caendesilva

  committed
  c0efe45

• Revert "Refactor control flow"

  Show description for 760af6b
  caendesilva

  committed
  760af6b

• Extract helper to get file contents

  caendesilva

  committed
  ac255ee

• Return null if file does not exist

  caendesilva

  committed
  20f764a

• Introduce local variable

  caendesilva

  committed
  b1ad1fc

• Check if contents is null

  caendesilva

  committed
  4ac8f35

• Replace ternary expression with if/else block

  caendesilva

  committed
  01d8833

• Set contents to default

  caendesilva

  committed
  7eb2dab

• Unwrap 'else'

  caendesilva

  committed
  dae62ba

• Flatten nested conditions

  caendesilva

  committed
  a62671d

• Null coalesce to default

  caendesilva

  committed
  c2b9f68

• Inline local variable

  caendesilva

  committed
  dfdceb3

• Revert "Inline local variable"

  Show description for 0e6b17f
  caendesilva

  committed
  0e6b17f

• Refactor other methods to use improved control flow

  caendesilva

  committed
  456bf34

• Extract helper method for shared code

  caendesilva

  committed
  acbe58b

• Move up method parameter in signature

  caendesilva

  committed
  877aa04

• Use callable method parameter

  Show description for 5fc1c1c
  caendesilva

  committed
  5fc1c1c

• Reorder methods in source

  Show description for 6b8e328
  caendesilva

  committed
  6b8e328

• Make extension optional

  caendesilva

  committed
  64eb92a

• Shift absolute path qualification to retrieval

  Show description for ea93261
  caendesilva

  committed
  ea93261

• Introduce local variable

  caendesilva

  committed
  83b2480

• Revert "Introduce local variable"

  Show description for 76b35dc
  caendesilva

  committed
  76b35dc

• Shift absolute path qualification to calling method

  Show description for c77d1fc
  caendesilva

  committed
  c77d1fc

• Normalize includes paths using same rules as other helpers

  Show description for 11a6015
  caendesilva

  committed
  11a6015

• Normalize control flow

  caendesilva

  committed
  9a07581

• Move extension to last in signature

  caendesilva

  committed
  15472ec

• Make extension optional

  caendesilva

  committed
  92fe45d

• Union type null instead of nullable short syntax

  caendesilva

  committed
  1c010cd

• Add no-op helper method

  caendesilva

  committed
  22c16d2

• Union type string return

  caendesilva

  committed
  daedfdf

• Use the helper method

  caendesilva

  committed
  7a7d9db

• Annotate callable generics

  caendesilva

  committed
  289ae7f

• Fix parameter annotation formatting

  caendesilva

  committed
  12d845e

• Inline no-op helper method into arrow function

  caendesilva

  committed
  36e8b5e

• Replace ternary expression with if/else block

  caendesilva

  committed
  cdcf30e

• Unwrap else block

  caendesilva

  committed
  f30d834

• Remove null union from callable that should not return it

  caendesilva

  committed
  befd302