Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Update the route helper function to throw if the route does not exist #1741

Merged
merged 1 commit into from
Jun 28, 2024
Merged

[2.x] Update the route helper function to throw if the route does not exist #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/framework/src/helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function asset(string $name, bool $preferQualifiedUrl = false): string
*/
function route(string $key): ?Hyde\Support\Models\Route
{
return hyde()->route($key);
return hyde()->routes()->getRoute($key);
}
}

Expand Down
8 changes: 2 additions & 6 deletions packages/framework/tests/Feature/HelpersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,9 @@ public function testRouteFunction()
/** @covers ::route */
public function testRouteFunctionWithInvalidRoute()
{
$this->assertNull(route('foo'));
}
$this->expectException(\Hyde\Framework\Exceptions\RouteNotFoundException::class);

/** @covers ::route */
public function testRouteFunctionReturnsNullForNonExistentRoute()
{
$this->assertNull(route('nonexistent'));
route('invalid');
}

/** @covers ::url */
Expand Down