Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Deprecate the BaseUrlNotSetException class #1759

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jun 29, 2024

This fixes part one of #1758. See #1760 for part two.

@caendesilva caendesilva marked this pull request as ready for review June 29, 2024 08:43
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (4b46ce7) to head (bc4aec6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1759   +/-   ##
=========================================
  Coverage     99.95%   99.95%           
  Complexity     1750     1750           
=========================================
  Files           181      181           
  Lines          4675     4675           
=========================================
  Hits           4673     4673           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva changed the title Deprecate the BaseUrlNotSetException class [1.x] Deprecate the BaseUrlNotSetException class Jun 29, 2024
@caendesilva caendesilva merged commit 4ccc8d2 into master Jun 29, 2024
23 checks passed
@caendesilva caendesilva deleted the deprecate-the-base-url-not-set-exception-class branch June 29, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant