Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal: Update tests to cover missing code coverage lines #1761

Merged
merged 11 commits into from
Jun 29, 2024
Merged

Internal: Update tests to cover missing code coverage lines #1761

merged 11 commits into from
Jun 29, 2024

Conversation

caendesilva
Copy link
Member

Fixes #1740

@caendesilva caendesilva linked an issue Jun 29, 2024 that may be closed by this pull request
Add missing code coverage #1740
Closed
@github-actions github-actions bot added the internal This pull request does not affect package code label Jun 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (221ac91) to head (5d90e95).
Report is 1 commits behind head on master.

❗ Current head 5d90e95 differs from pull request most recent head ef0afb7

Please upload reports for the commit ef0afb7 to get more accurate results.

Additional details and impacted files 
@@              Coverage Diff              @@
##             master     #1761      +/-   ##
=============================================
+ Coverage     99.95%   100.00%   +0.04%     
  Complexity     1750      1750              
=============================================
  Files           181       180       -1     
  Lines          4675      4674       -1     
=============================================
+ Hits           4673      4674       +1     
+ Misses            2         0       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the add-missing-code-coverage branch from 6ea7311 to adff736 Compare June 29, 2024 20:38
@caendesilva
Test with concrete class
42ca108
@caendesilva
Revert "Test with concrete class"
b25638f 
This reverts commit 42ca108.
@caendesilva
Revert "Generate unit test with Claude"
c0130c0 
This reverts commit adff736.
@caendesilva
Revert "Update unit test to cover base class"
e4174de 
This reverts commit 35e0ce1.
@caendesilva
Ignore code coverage for abstract method
5d90e95 
I feel like this should be handled by PHPUnit, as I don't see how it's possible to test it and it's only this one method that is an issue, maybe because it's inherited from an interface?
@caendesilva caendesilva force-pushed the add-missing-code-coverage branch from dfeac83 to 5d90e95 Compare June 29, 2024 20:47
@caendesilva caendesilva marked this pull request as ready for review June 29, 2024 20:48
@caendesilva caendesilva merged commit 1a32598 into master Jun 29, 2024
20 checks passed
@caendesilva caendesilva deleted the add-missing-code-coverage branch June 29, 2024 20:50
@caendesilva caendesilva mentioned this pull request Jun 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal This pull request does not affect package code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing code coverage
1 participant
@caendesilva