Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version prefix to the sitemap generator version attribute #1767

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

caendesilva
Copy link
Member

Fixes #1748 and normalizes with the behaviour that adds the version prefix to the HTML generator meta tag eade477

@caendesilva caendesilva linked an issue Jun 30, 2024 that may be closed by this pull request
@caendesilva caendesilva marked this pull request as ready for review June 30, 2024 18:01
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0f8d7e4) to head (5f2be75).
Report is 1 commits behind head on master.

Current head 5f2be75 differs from pull request most recent head a0913dd

Please upload reports for the commit a0913dd to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #1767   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1750      1750           
===========================================
  Files            180       180           
  Lines           4674      4674           
===========================================
  Hits            4674      4674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva merged commit b340e9a into master Jun 30, 2024
19 of 20 checks passed
@caendesilva caendesilva deleted the add-version-prefix-to-the-generator-string branch June 30, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.x] Should we add a version prefix to the generator string?
1 participant