Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Dynamic blogging related page generation #1843

Closed
wants to merge 142 commits into from

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jul 12, 2024

Abstract

Roadmap

Configuration idea

    'features' => [
        // Page Modules
        Feature::HtmlPages,
        Feature::MarkdownPosts,
        Feature::BladePages,
        Feature::MarkdownPages,
        Feature::DocumentationPages,

        // Frontend Features
        Feature::Darkmode,
        Feature::DocumentationSearch,

        // Integrations
        Feature::Torchlight,

        // Configurable Features (BlogPostAuthors implements ConfigurableFeature)
        BlogPostAuthors::configure(
            authorPages: true,
            authorListPage: true,
            authorUsernameFormat: 'kebab',
        ),
    ],

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2a97871) to head (6f1cbe3).

Additional details and impacted files
@@             Coverage Diff             @@
##             2.x-dev     hydephp/develop#1843   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1865      1877   +12     
===========================================
  Files            191       194    +3     
  Lines           4923      4964   +41     
===========================================
+ Hits            4923      4964   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the generate-author-pages branch 4 times, most recently from 25b4a30 to 4aa6f82 Compare July 12, 2024 19:43
@caendesilva
Copy link
Member Author

Had an idea that we could improve the realtime compiler route not found exception handling for pages like these, by showing the conditions needed for dynamic pages to show up. For example: Tip: An automatic Authors listing page is added when you have at least one blog post with an author defined

image

@caendesilva caendesilva force-pushed the generate-author-pages branch from 5f034c0 to e78dd2e Compare July 23, 2024 19:12
@caendesilva caendesilva force-pushed the generate-author-pages branch from 56720e5 to c38ff01 Compare July 24, 2024 10:11
@caendesilva
Copy link
Member Author

This is adding a ton of complexity, and will delay v2 quite a bit, so I'm going to hold off on this for the future.

@caendesilva caendesilva added the shelved-for-the-future Good ideas to revisit, but are not currently a priority. label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shelved-for-the-future Good ideas to revisit, but are not currently a priority.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant