[2.x] Improved dynamic Markdown links #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
improved-dynamic-markdown-links
branch
from
5e258bc to
a83f81c
Compare
caendesilva
force-pushed
the
improved-dynamic-markdown-links
branch
from
b0a6001 to
d4d8762
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dynamic-markdown-links #1901 +/- ##
==========================================================
Coverage 100.00% 100.00%
- Complexity 1870 1876 +6
==========================================================
Files 192 192
Lines 4941 4954 +13
==========================================================
+ Hits 4941 4954 +13 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
improved-dynamic-markdown-links
branch
from
ae55e3b to
9e613da
Compare
caendesilva
commented
Jul 25, 2024
packages/framework/src/Markdown/Processing/DynamicMarkdownLinkProcessor.php
Outdated
Show resolved
Hide resolved
This change makes it go from a constant ~2ms per call to essentially zero (0.000ms avg on 100 000 iterations)
This reverts commit 1b7bfcb.
caendesilva
force-pushed
the
improved-dynamic-markdown-links
branch
from
4bd6a59 to
76672b2
Compare
This reverts commit 851b17a. Cleaner is not always better.
Would take a ton of complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of something bigger.
Please see #1590 for information.