-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Automatically transliterate logographic inputs for slug generation #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
force-pushed
the
internationalization
branch
from
December 22, 2024 09:19
2453bc0
to
586492a
Compare
caendesilva
temporarily deployed
to
pr-documentation-2070
December 22, 2024 09:19 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2070 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1774 1775 +1
===========================================
Files 183 183
Lines 4782 4786 +4
===========================================
+ Hits 4782 4786 +4 ☔ View full report in Codecov by Sentry. |
Want to match #2059, but that would change output so deferring to v2.
caendesilva
temporarily deployed
to
pr-documentation-2070
December 22, 2024 10:54 — with
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-2070
December 22, 2024 11:04 — with
GitHub Actions
Inactive
caendesilva
temporarily deployed
to
pr-documentation-2070
December 22, 2024 11:04 — with
GitHub Actions
Inactive
caendesilva
changed the title
[1.x] Improve internationalization support
[1.x] Automatically transliterate logographic inputs for slug generation
Dec 22, 2024
caendesilva
added
the
internationalization
This makes improvements to internationalization
label
Dec 22, 2024
caendesilva
force-pushed
the
internationalization
branch
from
December 22, 2024 11:08
4106423
to
829f0e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new slug generation helper to improve internationalization support. Fixes hydephp/hyde#269