Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Automatically transliterate logographic inputs for slug generation #2070

Merged
merged 12 commits into from
Dec 22, 2024

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 22, 2024

Adds a new slug generation helper to improve internationalization support. Fixes hydephp/hyde#269

@caendesilva caendesilva temporarily deployed to pr-documentation-2070 December 22, 2024 09:19 — with GitHub Actions Inactive
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7d744de) to head (829f0e4).
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #2070   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1774      1775    +1     
===========================================
  Files            183       183           
  Lines           4782      4786    +4     
===========================================
+ Hits            4782      4786    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Want to match #2059, but that would change output so deferring to v2.
@caendesilva caendesilva temporarily deployed to pr-documentation-2070 December 22, 2024 10:54 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-2070 December 22, 2024 11:04 — with GitHub Actions Inactive
@caendesilva caendesilva temporarily deployed to pr-documentation-2070 December 22, 2024 11:04 — with GitHub Actions Inactive
@caendesilva caendesilva changed the title [1.x] Improve internationalization support [1.x] Automatically transliterate logographic inputs for slug generation Dec 22, 2024
@caendesilva caendesilva added the internationalization This makes improvements to internationalization label Dec 22, 2024
@caendesilva caendesilva marked this pull request as ready for review December 22, 2024 11:08
@caendesilva caendesilva merged commit 464bb8b into master Dec 22, 2024
23 checks passed
@caendesilva caendesilva deleted the internationalization branch December 22, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internationalization This makes improvements to internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chinese support
1 participant