Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CollectionService into DiscoveryService #290

Merged
merged 10 commits into from
Jul 29, 2022

Conversation

caendesilva
Copy link
Member

The collection service's name doesn't sit right with me. It doesn't actually deal with (Laravel) collections, just arrays. But it's integral to the Hyde auto-discovery process. And since the DiscoveryService class was deprecated anyways, why not merge them? Next step is to clean up the class and remove deprecated methods, but that's an other PR.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #290 (4d1d89e) into master (522b190) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #290   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       811       811           
===========================================
  Files             97        96    -1     
  Lines           2029      2029           
===========================================
  Hits            2029      2029           
Impacted Files Coverage Δ
.../Actions/GeneratesDocumentationSearchIndexFile.php 100.00% <100.00%> (ø)
.../framework/src/Commands/HydeBuildSearchCommand.php 100.00% <100.00%> (ø)
...mework/src/Commands/HydeBuildStaticSiteCommand.php 100.00% <100.00%> (ø)
.../Internal/TransfersMediaAssetsForBuildCommands.php 100.00% <100.00%> (ø)
packages/framework/src/Contracts/AbstractPage.php 100.00% <100.00%> (ø)
packages/framework/src/Services/BuildService.php 100.00% <100.00%> (ø)
...ckages/framework/src/Services/DiscoveryService.php 100.00% <100.00%> (ø)
...kages/framework/src/Services/ValidationService.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 522b190...4d1d89e. Read the comment docs.

@caendesilva caendesilva merged commit 2b20f63 into master Jul 29, 2022
@caendesilva caendesilva deleted the merge-collection-service-into-discovery-service branch July 29, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants