Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct the HTML page title inside the AbstractPage class #294

Merged
merged 3 commits into from
Jul 30, 2022

Conversation

caendesilva
Copy link
Member

This provides a canonical place to assemble the displayed page title, while also making it easier to customize from the backend in the future.

caendesilva and others added 2 commits July 30, 2022 15:31
This provides a canonical place to assemble the displayed page title, while also making it easier to customize from the backend in the future.
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #294 (0b02c7f) into master (6956bda) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0b02c7f differs from pull request most recent head eee9001. Consider uploading reports for the commit eee9001 to get more accurate results

@@             Coverage Diff             @@
##              master      #294   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       813       815    +2     
===========================================
  Files             96        96           
  Lines           2033      2038    +5     
===========================================
+ Hits            2033      2038    +5     
Impacted Files Coverage Δ
packages/framework/src/Contracts/AbstractPage.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6956bda...eee9001. Read the comment docs.

@caendesilva caendesilva merged commit dff5c54 into master Jul 30, 2022
@caendesilva caendesilva deleted the add-unified-page-title-helper branch July 30, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants