Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor page metadata generation #295

Merged
merged 34 commits into from
Jul 30, 2022

Conversation

caendesilva
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #295 (6d135e9) into master (dff5c54) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 6d135e9 differs from pull request most recent head aeebbfa. Consider uploading reports for the commit aeebbfa to get more accurate results

@@             Coverage Diff             @@
##              master      #295   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       815       815           
===========================================
  Files             96        97    +1     
  Lines           2038      2044    +6     
===========================================
+ Hits            2038      2044    +6     
Impacted Files Coverage Δ
packages/framework/src/Contracts/AbstractPage.php 100.00% <ø> (ø)
packages/framework/src/Helpers/Author.php 100.00% <ø> (ø)
packages/framework/src/Hyde.php 100.00% <ø> (ø)
...ages/framework/src/Concerns/HasArticleMetadata.php 100.00% <100.00%> (ø)
...ackages/framework/src/Concerns/HasPageMetadata.php 100.00% <100.00%> (ø)
...ramework/src/Exceptions/BaseUrlNotSetException.php 100.00% <100.00%> (ø)
packages/framework/src/Helpers/Meta.php 100.00% <100.00%> (ø)
packages/framework/src/HydeKernel.php 100.00% <100.00%> (ø)
...ckages/framework/src/Models/Pages/MarkdownPost.php 100.00% <100.00%> (ø)
packages/framework/src/Models/Route.php 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff5c54...aeebbfa. Read the comment docs.

@caendesilva caendesilva marked this pull request as ready for review July 30, 2022 15:39
@caendesilva caendesilva merged commit cec4949 into master Jul 30, 2022
@caendesilva caendesilva deleted the refactor-page-metadata-generation branch July 30, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants